Sunset and sunrise in Bangkok are pretty spectacular, not to be missed. There are few sites which I would recommend. Some of them are in the rooftop bars in the centre of the city, with a beautiful view of the skyline. Others are along the Chao Phraya River and the channels from there.
See a map with few of them in the Crazy traffic : Best places to make a photo in Bangkok